Added ytop_strategy_on_delete_waiting_time_seconds prometheus metric #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qurname2
force-pushed
the
qurname2/rolling-update-ondelete-metrics
branch
from
e58668e to
5468914
Compare
qurname2
force-pushed
the
qurname2/rolling-update-ondelete-metrics
branch
from
5468914 to
0d2a84e
Compare
koct9i
reviewed
Jan 7, 2026
koct9i
reviewed
Jan 7, 2026
pkg/metrics/update_strategy.go
Outdated
| Name: "on_delete_wait_seconds", | ||
| Help: "Seconds a component has been waiting in OnDelete mode since the mode started.", | ||
| }, | ||
| []string{"cluster", "component"}, |
Collaborator
There was a problem hiding this comment.
Let's pass
"cluster_namespace"
"cluster"
"component"
"component_name" - instance group name/role for proxies and nodes.
Collaborator
Author
There was a problem hiding this comment.
Let's have "cluster", "cluster_namespace" and "component_name". component_name will be either StatefulSet/Deployment short name (ms/hp) or short name with instance group name/role for proxies and nodes (default role is omitted).
example:
ytop_strategy_on_delete_waiting_time_seconds{cluster="test-ytsaurus",cluster_name
space="test-e2e-mfwbj",component_name="hp"}
ytop_strategy_on_delete_waiting_time_seconds{cluster="test-ytsaurus",cluster_name
space="test-e2e-mfwbj",component_name="hp-o11y"}
koct9i
reviewed
Jan 7, 2026
qurname2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effective usage would be after merging that PR